search

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 74 forks source link

Refactor deletion of Git-based domains #291

Open miq-bot opened 5 years ago

miq-bot commented 5 years ago

Refactor based on comments in: https://github.com/ManageIQ/manageiq/pull/12539#issuecomment-261018658

This issue was moved to this repository from https://github.com/ManageIQ/manageiq/issues/12696, originally opened by @gmcculloug

miq-bot commented 5 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

miq-bot commented 4 years ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

Fryguy commented 4 years ago

@NickLaMuro Is this already done via the work we did with embedded ansible?

NickLaMuro commented 4 years ago

@Fryguy My guess is "no" since I think the issues you had that caused this issue to be created were with naming/queue conventions outside the context of app/models/git_repository.rb and lib/git_worktree.rb.

https://github.com/ManageIQ/manageiq/pull/12539#issuecomment-261018658

I'm ok with merging as is, but there are some inconsistencies with the existing queueing (or task) pattern.

  • The model's destroy method should do the actual destroy (not on the queue)
  • The model should have a destroy_queue that calls destroy but through the queue.
  • The API and UI code should call destroy_queue
  • The external facing API endpoint should just be destroy (that is the User has no idea it's running off of the queue other than the fact that they get a task back)