MiqAeNamespace should use ancestry instead of acts_as_tree

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ

Apache License 2.0

11 stars 74 forks source link

MiqAeNamespace should use ancestry instead of acts_as_tree #409

Closed Fryguy closed 4 years ago

Fryguy commented 4 years ago

MiqAeNamespace is requested to walk its tree fairly frequently, but since it uses acts_as_tree, it effectively emits 1 query per level of the tree. One common path for this is asking an object's fqname. If MiqAeNamespace used ancestry, then it would be one query to get the fqname.

cc @tinaafitz

[x] Schema PR
[x] Core PR
[x] Automate Engine PR
[x] ~~UI PR~~ Not needed

kbrock commented 4 years ago

UI PR no longer needed.

NickLaMuro commented 4 years ago

I didn't do it! I swear! I'm innocent I say! INNOCENT!!!

(seriously though... no idea why it said I closed this...)

kbrock commented 4 years ago

The comment was "Fixes ManageIQ/manageiq-automation_engine#409" so the github will close the one fixed and claim the merger did it.