search

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 74 forks source link

Improve automate query performance. #439

Closed lfu closed 4 years ago

lfu commented 4 years ago

Columns domain_id and relative_path are added intoMiqAeNamespace, MiqAeClass, MiqAeInstance and MiqAeMethod.

Depends on https://github.com/ManageIQ/manageiq/pull/20050 Depends on https://github.com/ManageIQ/manageiq-schema/pull/465

cross repo tests: ManageIQ/manageiq-cross_repo-tests#112

Fixes https://github.com/ManageIQ/manageiq-automation_engine/issues/410

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 4039

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_object.rb 0 3 0.0%
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_domain_search.rb 6 10 60.0%
<!-- Total: 13 20 65.0% -->
Files with Coverage Reduction New Missed Lines %
app/models/miq_ae_browser.rb 1 92.54%
app/models/miq_ae_domain.rb 1 93.8%
lib/miq_automation_engine/engine/miq_ae_engine/drb_remote_invoker.rb 1 85.11%
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_domain_search.rb 1 84.38%
lib/miq_automation_engine/engine/miq_ae_method_service/miq_ae_service_object_common.rb 1 78.38%
lib/miq_automation_engine/service_models/miq_ae_service_service_reconfigure_request.rb 1 75.0%
lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_path.rb 2 91.11%
lib/miq_automation_engine/service_models/miq_ae_service_miq_provision_request.rb 2 79.31%
lib/miq_automation_engine/service_models/miq_ae_service_miq_request_task.rb 2 87.5%
lib/miq_automation_engine/service_models/mixins/miq_ae_service_miq_provision_mixin.rb 2 75.0%
<!-- Total: 941 -->
Totals Coverage Status
Change from base Build 3966: -16.4%
Covered Lines: 4102
Relevant Lines: 5896
💛 - Coveralls
kbrock commented 4 years ago

cross repo tests: https://github.com/ManageIQ/manageiq-cross_repo-tests/pull/112

lfu commented 4 years ago

@mkanoor @tinaafitz @gmcculloug Please review. Thanks.

gmcculloug commented 4 years ago

@lfu Hopefully will get time on this today or tomorrow.

miq-bot commented 4 years ago

Checked commit https://github.com/lfu/manageiq-automation_engine/commit/1142473ddd1cd6b03c3a34d687f2fe0ffc6c34cf with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 9 files checked, 0 offenses detected Everything looks fine. :star:

simaishi commented 4 years ago

Jansa backport details:

$ git log -1
commit 37b9eda551b70db8343f8d86798de194ba7e496e
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue May 12 10:01:57 2020 -0400

    Merge pull request #439 from lfu/add_ns_domain

    Improve automate query performance.

    (cherry picked from commit aa23c759ad3588ed67a308e9aa01316f817d9763)