ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 74 forks source link

fix failing automation manager spec #448

Closed d-m-u closed 4 years ago

d-m-u commented 4 years ago

fixes the build:

Failures:
  1) MiqAeMethodService::MiqAeServiceManageIQ_Providers_AnsibleTower_AutomationManager get the service model
     Failure/Error: expect(svc.name).to eq(automation_manager.name)
       expected: "ems_0000000000313 Automation Manager"
            got: "provider_0000000000004 Automation Manager"
       (compared using ==)
     # ./spec/service_models/miq_ae_service_manageiq-providers-ansible_tower-automation_manager_spec.rb:9:in `block (2 levels) in <top (required)>'

somewhere between https://github.com/ManageIQ/manageiq-providers-ansible_tower/pull/229 and https://github.com/ManageIQ/manageiq-providers-ansible_tower/commit/3a7a8bc9cf85df020c40252189544a7e1591eee3 is where this broke

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 4312


Totals Coverage Status
Change from base Build 4129: 0.0%
Covered Lines: 5019
Relevant Lines: 5853

💛 - Coveralls
miq-bot commented 4 years ago

Checked commit https://github.com/d-m-u/manageiq-automation_engine/commit/858db4fe8b97d78c0f861c84e173cde1544fbf6a with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 4 years ago

cc @agrare I think this happened because of a change on the tower provider side, right?

agrare commented 4 years ago

Yes, specifically this