add expose check_connection to generic service

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ

Apache License 2.0

11 stars 74 forks source link

add expose check_connection to generic service #465

Closed d-m-u closed 3 years ago

d-m-u commented 3 years ago

We need to expose check_connection, see the rest of the related changes on https://github.com/ManageIQ/manageiq/pull/20773.

@miq-bot add_label ivanchuk/yes

part of https://bugzilla.redhat.com/show_bug.cgi?id=1835226 fix

miq-bot commented 3 years ago

Checked commit https://github.com/d-m-u/manageiq-automation_engine/commit/19f2e6d4727b8eb7da4842a343e06e491ad439b9 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie:

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 4670

0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 85.763%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
lib/miq_automation_engine/service_models/miq_ae_service_service_generic.rb	0	1	0.0%
<!--	Total:	0	1	0.0%	-->

Totals
Change from base Build 4612:	0.02%
Covered Lines:	5018
Relevant Lines:	5851

💛 - Coveralls

simaishi commented 3 years ago

Ivanchuk backport details:

$ git log -1
commit 9211d19af417a131df8de43dab18141d5d2af70f
Author: tina <tfitzger@redhat.com>
Date:   Thu Nov 12 10:06:13 2020 -0500

    Merge pull request #465 from d-m-u/adding_check_connection_expose

    add expose check_connection to generic service

    (cherry picked from commit e0aa23f340d4fb2e689205697a10a4a251f13311)

    https://bugzilla.redhat.com/show_bug.cgi?id=1835226

simaishi commented 3 years ago

Jansa backport details:

$ git log -1
commit adfb7d591b341b0468f2654b538f0d8cdd24b50b
Author: tina <tfitzger@redhat.com>
Date:   Thu Nov 12 10:06:13 2020 -0500

    Merge pull request #465 from d-m-u/adding_check_connection_expose

    add expose check_connection to generic service

    (cherry picked from commit e0aa23f340d4fb2e689205697a10a4a251f13311)

simaishi commented 3 years ago

Kasparov backport details:

$ git log -1
commit c798cda01ffc0cb03f8634242006ed02e810a6af
Author: tina <tfitzger@redhat.com>
Date:   Thu Nov 12 10:06:13 2020 -0500

    Merge pull request #465 from d-m-u/adding_check_connection_expose

    add expose check_connection to generic service

    (cherry picked from commit e0aa23f340d4fb2e689205697a10a4a251f13311)