Move $miq_ae_logger initialization and configuration into plugin

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ

Apache License 2.0

11 stars 74 forks source link

Move $miq_ae_logger initialization and configuration into plugin #470

Closed Fryguy closed 3 years ago

Fryguy commented 3 years ago

@agrare Please review.

From what I can tell the only callers of this left are in ui-classic (here), which I'm wondering if we can hide behind something like a ManageIQ::AutomationEngine.logger

miq-bot commented 3 years ago

Checked commit https://github.com/Fryguy/manageiq-automation_engine/commit/c0636fe93348fd5bc0576b742a597f0b006ddb18 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :+1:

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 4954

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 85.773%

Totals
Change from base Build 4836:	0.02%
Covered Lines:	5022
Relevant Lines:	5855

ManageIQ / manageiq-automation_engine

Move $miq_ae_logger initialization and configuration into plugin #470

Pull Request Test Coverage Report for Build 4954

💛 - Coveralls