[StateVarHash] Add VMDBLogger.log_hashes to filter

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ

Apache License 2.0

11 stars 74 forks source link

[StateVarHash] Add VMDBLogger.log_hashes to filter #481

Closed NickLaMuro closed 3 years ago

NickLaMuro commented 3 years ago

Filters the "Reloading state var data: ..." line using .log_hashes so that sensitive data is not added to the logs.

Partially Addresses https://github.com/ManageIQ/manageiq/issues/21392

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 5695

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.002%) to 85.743%

Totals
Change from base Build 5655:	0.002%
Covered Lines:	5052
Relevant Lines:	5892

💛 - Coveralls

Fryguy commented 3 years ago

Should this include a test that filters out a password?

NickLaMuro commented 3 years ago

100% agree. Thought about doing the same after I made the PR, so we are both on the same page.

miq-bot commented 3 years ago

Checked commit https://github.com/NickLaMuro/manageiq-automation_engine/commit/2974e207d4a3d5322bb98982d186452d8fd98b24 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 3 years ago

Backported to morphy in commit 87175d9549299f4013663a0e9096590fcf088cdc.

commit 87175d9549299f4013663a0e9096590fcf088cdc
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Sep 1 16:52:35 2021 -0400

    Merge pull request #481 from NickLaMuro/filter-passwords-in-state-var-hash-logging

    [StateVarHash] Add VMDBLogger.log_hashes to filter

    (cherry picked from commit 3927aea68291be87b6b4f43a170c8b0f64132e60)