[StateVarHash] Use .secret_filter

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ

Apache License 2.0

11 stars 74 forks source link

[StateVarHash] Use .secret_filter #482

Closed NickLaMuro closed 3 years ago

NickLaMuro commented 3 years ago

.secret_filter allows for user customized attribute keys to be filtered out, so leverage that here, as PASSWORD_FIELDS is still combined with that value (even if none exists).

miq-bot commented 3 years ago

Checked commit https://github.com/NickLaMuro/manageiq-automation_engine/commit/16b19991861fff7467c75da97a01d1b58d9e6f7f with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake:

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 5750

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 85.743%

Totals
Change from base Build 5716:	0.0%
Covered Lines:	5052
Relevant Lines:	5892

💛 - Coveralls

Fryguy commented 3 years ago

Backported to morphy in commit 00bf5cc73958013bb38eed0a411ff73f66d702de.

commit 00bf5cc73958013bb38eed0a411ff73f66d702de
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Sep 9 17:42:47 2021 -0400

    Merge pull request #482 from NickLaMuro/use-password-filter-method-for-log-hashes

    [StateVarHash] Use .secret_filter

    (cherry picked from commit 0367803fb61dfa1919cffc388d9d936a75d8f505)