search

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 73 forks source link

Handle a nil svc in DrbRemoteInvoker#with_server #512

Closed agrare closed 1 year ago

agrare commented 1 year ago

The ensure section of the DrbRemoteInvoker#with_server method does not handle an exception raised before svc is set and thus can call nil.destroy.

miq-bot commented 1 year ago

Checked commit https://github.com/agrare/manageiq-automation_engine/commit/5e1c5feeeb62f01c87b1c2ce52345b77fda17e5f with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie:

Fryguy commented 1 year ago

Backported to oparin in commit f17fec5db8a554252f8ba5709270103250cf4be6.

commit f17fec5db8a554252f8ba5709270103250cf4be6
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Nov 4 17:13:37 2022 -0400

    Merge pull request #512 from agrare/handle_nil_svc_drb_remote_invoker_with_server

    Handle a nil svc in DrbRemoteInvoker#with_server

    (cherry picked from commit c45a3e0a6ff331a3a1e9eb0c49947b99449eb11c)
Fryguy commented 1 year ago

Backported to najdorf in commit 03e1caa15a8c22aff4d6ff5b198d683307da784b.

commit 03e1caa15a8c22aff4d6ff5b198d683307da784b
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Nov 4 17:13:37 2022 -0400

    Merge pull request #512 from agrare/handle_nil_svc_drb_remote_invoker_with_server

    Handle a nil svc in DrbRemoteInvoker#with_server

    (cherry picked from commit c45a3e0a6ff331a3a1e9eb0c49947b99449eb11c)
Fryguy commented 1 year ago

Backported to morphy in commit 54deb93150704f68cd47703c3b6d5d7a1ac9e75f.

commit 54deb93150704f68cd47703c3b6d5d7a1ac9e75f
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Nov 4 17:13:37 2022 -0400

    Merge pull request #512 from agrare/handle_nil_svc_drb_remote_invoker_with_server

    Handle a nil svc in DrbRemoteInvoker#with_server

    (cherry picked from commit c45a3e0a6ff331a3a1e9eb0c49947b99449eb11c)