Closed DavidResende0 closed 1 year ago
@miq-bot assign @Fryguy
Discussed with @DavidResende0 and we are skipping the bot suggestion because the current code stays consistent with the other trivial accessors in the file.
@DavidResende0 I updated a bunch of stuff here - Going to look at the core changes and regular $log
changes tomorrow, but I think I might keep the $request_log
, but instead make it just delegate to $log
.
Too tired tonight though 😴
@DavidResende0 I'm seeing some issues locally caused by https://github.com/ManageIQ/manageiq-automation_engine/pull/519, but those are unrelated. Hoping to get that merged first, then I can rebase this.
lib/manageiq/automation_engine/logger.rb
||
instead of or
.lib/miq_automation_engine/engine/miq_ae_engine.rb
spec/miq_ae_service_spec.rb
Parent Issue: https://github.com/ManageIQ/manageiq/issues/21188 Continuation of: https://github.com/ManageIQ/manageiq-automation_engine/pull/503