ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 73 forks source link

Add logging to RequestLog model #516

Closed DavidResende0 closed 1 year ago

DavidResende0 commented 1 year ago

Parent Issue: https://github.com/ManageIQ/manageiq/issues/21188 Continuation of: https://github.com/ManageIQ/manageiq-automation_engine/pull/503

DavidResende0 commented 1 year ago

@miq-bot assign @Fryguy

Fryguy commented 1 year ago

Discussed with @DavidResende0 and we are skipping the bot suggestion because the current code stays consistent with the other trivial accessors in the file.

Fryguy commented 1 year ago

@DavidResende0 I updated a bunch of stuff here - Going to look at the core changes and regular $log changes tomorrow, but I think I might keep the $request_log, but instead make it just delegate to $log.

Too tired tonight though 😴

Fryguy commented 1 year ago

@DavidResende0 I'm seeing some issues locally caused by https://github.com/ManageIQ/manageiq-automation_engine/pull/519, but those are unrelated. Hoping to get that merged first, then I can rebase this.

miq-bot commented 1 year ago

Checked commit https://github.com/DavidResende0/manageiq-automation_engine/commit/f28f0a2e75d1ca3b95dd5023e8395ec327a495a9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 18 files checked, 13 offenses detected

lib/manageiq/automation_engine/logger.rb

lib/miq_automation_engine/engine/miq_ae_engine.rb

spec/miq_ae_service_spec.rb