search

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 73 forks source link

[WIP] Add fake interface for workflow execution, temporarily #517

Closed Fryguy closed 1 year ago

Fryguy commented 1 year ago

cc @agrare

miq-bot commented 1 year ago

Checked commit https://github.com/Fryguy/manageiq-automation_engine/commit/9fd974054d1d2e9ac44982c3a4f562bfd503031d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 1 offense detected

lib/miq_automation_engine/engine/miq_ae_engine.rb

Fryguy commented 1 year ago

Marked this PR as WIP because it is a hack to get the PoC working.

agrare commented 1 year ago

Again, that wait in here really stands out since the others seem to exit with putting work into the queue.

The normal automate deliver is blocking as well so the wait_for_task works the same way

Fryguy commented 1 year ago

@agrare What I think we should do, to be honest, is have a new Automation entrypoint that is plugin-agnostic. This way we can start moving away from Automate to a generic interface.

Also thinking this might be used by Embedded Ansible or even Ansible Tower directly potentially.

agrare commented 1 year ago

Yeah absolutely, if "automate" is an EmbeddedAutomationManager we could standardize on that. Would also be interesting to see if we could run automate methods as a Resource in an ASL state machine

miq-bot commented 1 year ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s)

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

agrare commented 1 year ago

This is no longer needed and can be closed