permit_concurrent_loads is not needed with zeitwerk autoloader

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ

Apache License 2.0

11 stars 73 forks source link

permit_concurrent_loads is not needed with zeitwerk autoloader #537

Closed jrafanie closed 8 months ago

jrafanie commented 8 months ago

This was only needed for classic autoloader. The core "freedom" patch made zeitwerk autoloader bypass the interlock anyway, so now that we're only supporting zeitwerk, this is no longer needed.

Co-dependency: https://github.com/ManageIQ/manageiq/pull/22801

Part of the rails 7 upgrade: https://github.com/ManageIQ/manageiq/issues/22052

miq-bot commented 8 months ago

Some comments on commit https://github.com/jrafanie/manageiq-automation_engine/commit/f685f122161faf97729b61d9f5e1d399ea366ee1

lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_method.rb

[ ] :warning: - 149 - Detected puts. Remove all debugging statements.

miq-bot commented 8 months ago

Checked commit https://github.com/jrafanie/manageiq-automation_engine/commit/f685f122161faf97729b61d9f5e1d399ea366ee1 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy:

jrafanie commented 8 months ago

This is ready to go since we were already defaulting to zeitwerk on quinteros

Fryguy commented 7 months ago

Backported to quinteros in commit 344e02aa10fb242c36236ead687f2694ce18cb16.

commit 344e02aa10fb242c36236ead687f2694ce18cb16
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Dec 19 14:33:34 2023 -0500

    Merge pull request #537 from jrafanie/drop_as_dependencies_interlock_with_classic_autoloader_gone

    permit_concurrent_loads is not needed with zeitwerk autoloader

    (cherry picked from commit 29852c42ad3240874945edcb16ea4b3de50ed6a0)