search

ManageIQ / manageiq-automation_engine

Automation engine for ManageIQ
Apache License 2.0
11 stars 73 forks source link

Remove prepend_namespace #551

Open kbrock opened 1 month ago

kbrock commented 1 month ago

We do not use prepend_namespace The feature is causing us to double the number of queries when looking up objects

@Fryguy you mentioned that we are not using this. It was an extension mechanism added by tina that seems to not be leveraged.

I just put this into a PR so I didn't have to have a local branch and have to remember where I saw this issue.

miq-bot commented 1 month ago

Checked commit https://github.com/kbrock/manageiq-automation_engine/commit/0885f2450ff52bb457048a313523763602a77619 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 6 files checked, 0 offenses detected Everything looks fine. :trophy:

Fryguy commented 1 month ago

Oh interesting. So the vendor part of this was part of an idea to create namespaces for plugins. Plugins could then own their own namespace or even domain, and then provide concrete implementations of things like provisioning and event handling, where the core automation engine would have generic stuff and call into plug-in specific stuff.

I don't believe this was ever completed, but do you see any vendor specific namespaces in manageiq-content?

cc @agrare

agrare commented 1 month ago

I don't recognize any of this but I like the idea of moving provider specific automate bits into their respective plugins

kbrock commented 1 month ago

@Fryguy I didn't look. I remember you saying that Tina introduced this but we never ended up using it (6 months ago when I was tracing automate), and I saw a branch yesterday and finally pushed it forward.

When tracing the queries and walking through the code, it is a distraction to me, especially knowing they are useless queries.

Fryguy commented 1 month ago

Yeah my only concern is that there is already some vendor namespaces built, that this would effectively break. If not, then I think we can merge.