Do not require prov. dialog to set :number_of_vms

ManageIQ / manageiq-content

Default ManageIQ content

Apache License 2.0

13 stars 120 forks source link

Do not require prov. dialog to set :number_of_vms #718

Closed jaywcarman closed 2 years ago

jaywcarman commented 2 years ago

For some provisioning dialogs it makes sense to assume the number of VMs is 1. For example, when provisioning a template from an existing VM. The VmName suffix method can safely treat a nil :number_of_vms the same as :number_of_vms == 1, eliminating the need to set the value explicitly in the provider dialog.

Related to:

ManageIQ/manageiq-providers-ibm_cloud#418

jaywcarman commented 2 years ago

LGTM. Are there tests for this?

There's already a "provisions single vm". I could add:

"provisions with number_of_vms not set"
"provisions with multiple vms"

Any others?

Fryguy commented 2 years ago

Backported to oparin in commit ebab9a3e1eef82698f76b5fb94055b0feae520e6.

commit ebab9a3e1eef82698f76b5fb94055b0feae520e6
Author: Joe Rafaniello <jrafanie@users.noreply.github.com>
Date:   Thu Sep 1 18:00:21 2022 -0400

    Merge pull request #718 from jaywcarman/fix_required_number_of_vms

    (cherry picked from commit 74efdb04646bbb78ad3e969efc571ddf2ef5ac4e)