search

ManageIQ / manageiq-content

Default ManageIQ content
Apache License 2.0
13 stars 120 forks source link

Multiple notifications bug fix #721

Closed akhilkr128 closed 2 years ago

akhilkr128 commented 2 years ago

Getting Multiple Notifications in my Services Catalog.

  1. Multiple notifications after the service provision Screenshot 2022-10-19 at 12 36 05 AM
  2. Two error messages are showing when an error happens between the provision. Screenshot 2022-10-19 at 12 36 05 AM

Fix

Added a duplication check before creating notifications.

miq-bot commented 2 years ago

Checked commits https://github.com/akhilkr128/manageiq-content/compare/b4c38b28c95c6e450f2efe629a5ac0e6147ecc86~...4e02def40ba938a9408dd324ec750ff1d8ea1b50 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 2 years ago

I'm not sure multiple errors is a problem because if some error actually continually occurs, then it should be said to the user. The weird part is more the multiple successes.