search

ManageIQ / manageiq-content

Default ManageIQ content
Apache License 2.0
13 stars 120 forks source link

Add physical server profile template #723

Closed tzurvaza closed 2 years ago

tzurvaza commented 2 years ago

fix alescernivec/manageiq-providers-cisco_intersight#78

Related PRs

https://github.com/ManageIQ/manageiq/pull/22241 https://github.com/ManageIQ/manageiq-providers-cisco_intersight/pull/81 https://github.com/ManageIQ/manageiq-schema/pull/673 https://github.com/ManageIQ/manageiq-automation_engine/pull/514

ereztheodorou commented 2 years ago

@agrare these PRs are to be included in the upcoming release (need to be reviewed and approved)

agrare commented 2 years ago

Depends on https://github.com/ManageIQ/manageiq-automation_engine/pull/514

agrare commented 2 years ago

Overall looks good just a couple of questions/comments

miq-bot commented 2 years ago

Checked commits https://github.com/Autosde/manageiq-content/compare/7eb3ef8e6868d70926826edb6de5c69cb4d76dc1~...79418c71a0ac9620215d39957b01cda8688e3ee8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 4 files checked, 0 offenses detected Everything looks fine. :cake:

eilam20 commented 2 years ago

@agrare can you merge it?

agrare commented 2 years ago

@ereztheodorou code freeze for oparin backport was over a month ago, this will land in the petrosian release