ManageIQ / manageiq-documentation

Documentation for the ManageIQ Management Platform
https://www.manageiq.org/docs/
Other
38 stars 112 forks source link

Add root key to internal certificate secret example #1741

Closed nasark closed 1 year ago

nasark commented 1 year ago

@miq-bot assign @bdunne @miq-bot add_reviewer @Fryguy @miq-bot add_label enhancement

miq-bot commented 1 year ago

Checked commit https://github.com/nasark/manageiq-documentation/commit/64760e1d2ac46a8032e8b23789583197fabe0f67 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :+1:

bdunne commented 1 year ago

the root key is needed for downstream Kafka SSL configuration

Why would any server need the CA private key? This feels like a CVE waiting to happen It shouldn't even need the CA public key unless it is attempting to connect to itself (for debugging purposes) or to another server signed by that CA

nasark commented 1 year ago

Why would any server need the CA private key? This feels like a CVE waiting to happen It shouldn't even need the CA public key unless it is attempting to connect to itself (for debugging purposes) or to another server signed by that CA

@bdunne It's not required by us but rather Strimzi does a check to see if the following secrets are available https://strimzi.io/docs/operators/in-development/deploying.html#installing-your-own-ca-certificates-str. If <cluster_name>-cluster-ca secret which contains the ca key is not available then Kafka is not deployed. Usually Strimzi generates the ca key/certs and creates the secrets for you but since we are bringing our own certs in the form of internalCertificateSecret then it needs to be specified here

Fryguy commented 1 year ago

Backported to quinteros in commit af0da36deb8457ed0bc9adb839e504d0538db220.

commit af0da36deb8457ed0bc9adb839e504d0538db220
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Sep 1 09:35:30 2023 -0400

    Merge pull request #1741 from nasark/add_root_key_pods_ssl

    Add root key to internal certificate secret example

    (cherry picked from commit 3d2f26d15affc13255d4af94ac4fe55e6167a372)