ManageIQ / manageiq-documentation

Documentation for the ManageIQ Management Platform
https://www.manageiq.org/docs/
Other
38 stars 113 forks source link

Update editing_a_containers_provider.md #1745

Closed rwellon closed 11 months ago

rwellon commented 11 months ago

Pull request to add a note regarding the limitation for configuring Prometheus alerts for a container provider.

rwellon commented 11 months ago

@miq-bot assign @Fryguy

rwellon commented 11 months ago

@miq-bot assign @agrare

rwellon commented 11 months ago

@miq-bot add_labels petrosian/yes? oparin/yes? quinteros/yes?

miq-bot commented 11 months ago

@rwellon Cannot apply the following label because they are not recognized:

All labels for ManageIQ/manageiq-documentation: https://github.com/ManageIQ/manageiq-documentation/labels

Fryguy commented 11 months ago

@rwellon Do you need this backported to any specific versions?

agrare commented 11 months ago

We still had the alerts endpoint in the container_manager create form, https://github.com/ManageIQ/manageiq-providers-kubernetes/pull/506

miq-bot commented 11 months ago

Checked commits https://github.com/rwellon/manageiq-documentation/compare/bd1d895bda9b703d5cc16fee55094441d0e93033~...10b85663127d1422612c1dfe7f33fa2b08a1b755 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :trophy:

miq-bot commented 11 months ago

Some comments on commits https://github.com/rwellon/manageiq-documentation/compare/bd1d895bda9b703d5cc16fee55094441d0e93033~...10b85663127d1422612c1dfe7f33fa2b08a1b755

https://github.com/ManageIQ/manageiq-documentation/commit/10b85663127d1422612c1dfe7f33fa2b08a1b755

agrare commented 11 months ago

@rwellon it looks like you tried to merge master into this branch, as a project we rebase PR branches on master rather than merging master into the branch just to keep the history clean and not have more merge commits than necessary.

You can refer to the git workflow https://www.manageiq.org/docs/guides/developer_setup/git_workflow specifically git config --global --bool pull.rebase true or you can git fetch upstream; git rebase upstream/master

rwellon commented 11 months ago

Closing this PR - will remove content in new PR