search

ManageIQ / manageiq-documentation

Documentation for the ManageIQ Management Platform
https://www.manageiq.org/docs/
Other
38 stars 113 forks source link

Add procedure to specify docker pull secret for embedded workflow #1760

Closed aileenjackson closed 9 months ago

aileenjackson commented 9 months ago

Commits included.

Fryguy commented 9 months ago

@aileenjackson It seems some bonus whitespace was added - can you remove that throughout the document? For example:

For `Task` type steps in the workflow, a       docker container

should be 

For `Task` type steps in the workflow, a docker container
Fryguy commented 9 months ago

@aileenjackson Can you please also update the PR title to more accurately describe the changes?

agrare commented 9 months ago

Hey @aileenjackson can you update the PR description and squash the commits since it doesn't appear this specific history is going to be helpful?

miq-bot commented 9 months ago

Checked commit https://github.com/aileenjackson/manageiq-documentation/commit/876bd8cce7e3585491662265aad9d26274a6d5ad with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 9 months ago

Backported to quinteros in commit 38c97db17d892d18bee669e0afd9739ba7200a46.

commit 38c97db17d892d18bee669e0afd9739ba7200a46
Author: Jason Frey <fryguy9@gmail.com>
Date:   Tue Nov 14 17:36:08 2023 -0500

    Merge pull request #1760 from aileenjackson/patch-2

    Add procedure to specify docker pull secret for embedded workflow

    (cherry picked from commit cc5de9492aa6e861ed374ed4aace761d0056d949)
aileenjackson commented 9 months ago

@Fryguy Looks good in ManageIQ docs - https://www.manageiq.org/docs/reference/latest/managing_providers/. I presume it will be automatically added to IBM docs also? Thanks Aileen