Messaging hostname guideline updates

ManageIQ / manageiq-documentation

Documentation for the ManageIQ Management Platform

https://www.manageiq.org/docs/

Other

38 stars 113 forks source link

Messaging hostname guideline updates #1778

Closed nasark closed 7 months ago

nasark commented 7 months ago

Based on feedback received from @mikemoroney and @aileenjackson, please review

@miq-bot add_label enhancement, quinteros/yes? @miq-bot assign @Fryguy

jrafanie commented 7 months ago

@mikemoroney please take a look...

mikemoroney commented 7 months ago

Thanks for the update - LGTM

miq-bot commented 7 months ago

Checked commit https://github.com/nasark/manageiq-documentation/commit/bb65b88c67bff400955c8ed019f375f3bd657ece with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :trophy:

nasark commented 7 months ago

Applied @aileenjackson's feedback:

updated AWS hyperlink according to downstream standards

Fryguy commented 7 months ago

Backported to quinteros in commit 0fa05176ad76df6b0695b3fea4416f5c699b4056.

commit 0fa05176ad76df6b0695b3fea4416f5c699b4056
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Jan 24 14:22:10 2024 -0500

    Merge pull request #1778 from nasark/hostname_guidelines

    Messaging hostname guideline updates

    (cherry picked from commit c2ac3f3c05f2c6d9d7410e6b27909c85ac9763f6)