search

ManageIQ / manageiq-documentation

Documentation for the ManageIQ Management Platform
https://www.manageiq.org/docs/
Other
38 stars 113 forks source link

QA opentofu provider #1793

Closed qahmed1998 closed 2 months ago

qahmed1998 commented 2 months ago
qahmed1998 commented 2 months ago

@miq-bot assign @Fryguy

qahmed1998 commented 2 months ago

@miq-bot add_labels radjabov/yes

agrare commented 2 months ago

TODO before merge, amend the WIP commit with a helpful commit message https://github.com/ManageIQ/manageiq-documentation/pull/1793/commits/553132c8c936c716f503e5f2463765d519838284

miq-bot commented 2 months ago

Checked commits https://github.com/qahmed1998/manageiq-documentation/compare/553132c8c936c716f503e5f2463765d519838284~...8863f08ca8e78c8d92758221e35e4308745e5e4c with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cookie:

Fryguy commented 2 months ago

Overall, LGTM. I'm going to merge, even though technically we don't have the opentofu runner available yet, but plan to by the time this is released.

The minor stuff can be in a follow up PR.

Fryguy commented 2 months ago

Backported to radjabov in commit 11a0d3c606e3cb8527e9a8c0a42095f8e866f657.

commit 11a0d3c606e3cb8527e9a8c0a42095f8e866f657
Author: Jason Frey <fryguy9@gmail.com>
Date:   Wed Jun 26 13:18:01 2024 -0400

    Merge pull request #1793 from qahmed1998/QA-opentofu-provider

    QA opentofu provider

    (cherry picked from commit 961dfea2cf651f2bb158912c4bbf17a77daf3f7a)