Closed qahmed1998 closed 6 days ago
@qasim-ahmed This PR is going to need a bunch of "prior" entries, so that the page detector can understand how the pages were moved around. Basically, the way it works is for each of these "moved" sections, just add a new key called "prior" which is the url for the old location of the file. Here's an example from when we moved one of the locations from morphy to najdorf: https://github.com/ManageIQ/manageiq-documentation/blob/najdorf/_data/site_menu.yml#L42
@qasim-ahmed Can you also update the original post here with maybe a screenshot or a manual type-out of the new layout? Also, please update the PR title / commit message to be more descriptive - this is a pretty big change, and the title doesn't really reflect that.
Installing section:
Upgrading section:
Administration section:
Visualizing section:
Controls section:
Managing integrations section:
APIs, Reference and Troubleshhooting sections:
@agrare @jrafanie Please also take a look.
Hi @agrare @jrafanie Please take a look when you get a chance.
@qahmed1998 how can I see a before and after?
It's hard to visualize what's moving around and being added/removed. I'll add my comments but they're on the existing terminology so mostly unrelated to this PR.
@qahmed1998 how can I see a before and after?
It's hard to visualize what's moving around and being added/removed. I'll add my comments but they're on the existing terminology so mostly unrelated to this PR.
We can potentially merge and see the ToC?
We can potentially merge and see the ToC?
I think that defeats the purpose of PR review if we have to merge it to see it, agree with @jrafanie it is hard to review without seeing what has changed easier
I have posted screenshots above as well. The ss might help!
Ok, this is the before... I think I can imagine what it will look like:
The changes in this PR include, adding new top level headings, moving topics from one heading to another and adding topics which existed but were not part of the ToC. The ToC changes that are in this PR currently aligns with the downstream (AIOps) ToC.
The ToC changes that are in this PR currently aligns with the downstream (AIOps) ToC.
Okay it seems like some items might be in the wrong place there then also so lets put them in the best place upstream first :tm: and go from there
The ToC changes that are in this PR currently aligns with the downstream (AIOps) ToC.
Okay it seems like some items might be in the wrong place there then also so lets put them in the best place upstream first ™️ and go from there
Yeah sounds good to me.
NOTE I don't see Automation Management Providers
in the existing TOC, can we add under Managing Providers
similar to Configuration Providers
NOTE I don't see
Automation Management Providers
in the existing TOC, can we add underManaging Providers
similar toConfiguration Providers
Do you have the URL/path of the file/content?
Okay so from our discussions in Slack, this is what we have as updated ToC.
Installing
Upgrading
Using
General Configuration
Monitoring, alerts, reporting
Policies and Profiles Guide
Managing Infrastructure and Inventory
Managing Providers and its sub-topics
Provisioning Virtual Machines and Hosts
Scripting Actions in ManageIQ
Creating a Service in for Virtual Machine Provisioning
Service Provisioning Using an Orchestration Template
Managing controls (seems the most suitable name to me as a heading)
Monitoring, alerts, reporting
Policies and Profiles Guide
Assigning a Custom Analysis Profile to a Virtual Machine
Administering Infrastructure Management
Authentication
Backup and Restore (appliances)
Deployment planning guide
High Availability Guide
Appliance Hardening Guide
Defining integrations
AWS CloudFormation and OpenStack Heat
ServiceNow
APIs
Reference
Capabilities Matrix
Methods available for automation
Troubleshooting (same as it is)
Any final adjustments or am I good to make this as the ToC in the PR?
Okay so from our discussions in Slack, this is what we have as updated ToC.
Looks good to me for reorganizing things! We can iterate on it going forward.
Updated ToC as we discussed. Please review.
Automation Management Providers
topic in ToCChargeback
topic in ToC@jrafanie @Fryguy are we good to merge?
Hi Joe, I have addressed your comments.
**
This PR broke the build
Psych::SyntaxError: (/tmp/manageiq-documentation/_data/site_menu.yml): mapping values are not allowed in this context at line 7 column 17
/tmp/manageiq-documentation/Rakefile:10:in `block in <top (required)>'
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle:23:in `load'
/opt/hostedtoolcache/Ruby/2.7.8/x64/bin/bundle:23:in `<main>'
Tasks: TOP => build
(See full trace by running task with --trace)
Should be fixed by https://github.com/ManageIQ/manageiq-documentation/pull/1812
Weird it passed in the PR. 😕
This PR also "broke" the user reference page - https://github.com/ManageIQ/manageiq.org/blob/master/site/docs/reference/index.md?plain=1
I wonder if instead of hardcoding the sections we can more dynamically build it up. Even so, the {{}}
stuff won't work there because it's dynamically built.
This PR also "broke" the user reference page - https://github.com/ManageIQ/manageiq.org/blob/master/site/docs/reference/index.md?plain=1
I wonder if instead of hardcoding the sections we can more dynamically build it up. Even so, the
{{}}
stuff won't work there because it's dynamically built.
@qahmed1998 see above
Added following additional topics to ToC:
This PR is editing the current ToC for ManageIQ. No files in terms of their locations were moved in the process. 3 existing topics (as mentioned above) were added to the ToC.