Allow rails 7 gems in gemspec

ManageIQ / manageiq-gems-pending

Gems Pending to be extracted for ManageIQ project.

Other

3 stars 79 forks source link

Allow rails 7 gems in gemspec #570

Closed jrafanie closed 10 months ago

jrafanie commented 10 months ago

Allow rails 7 gems in gemspec

jrafanie commented 10 months ago

@agrare since you work on some gems that consume gems pending, what do you think of this PR and most importantly, the note above about loosening the activesupport dependency so the consuming application or gem can dictate the upper bound on the version constraint?

miq-bot commented 10 months ago

Some comments on commits https://github.com/jrafanie/manageiq-gems-pending/compare/ea3cf6d45bf3f9973648618706f352da752f5333~...ab7a82b85c03333040612ea8d884b422e9b19a56

spec/spec_helper.rb

[ ] :warning: - 39 - Detected puts. Remove all debugging statements.
[ ] :warning: - 40 - Detected puts. Remove all debugging statements.

miq-bot commented 10 months ago

Checked commits https://github.com/jrafanie/manageiq-gems-pending/compare/ea3cf6d45bf3f9973648618706f352da752f5333~...ab7a82b85c03333040612ea8d884b422e9b19a56 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 2 files checked, 1 offense detected

Gemfile

[x] :exclamation: - Line 10, Col 8 - Style/FetchEnvVar - Use ENV.fetch('TEST_RAILS_VERSION') or ENV.fetch('TEST_RAILS_VERSION', nil) instead of ENV['TEST_RAILS_VERSION'].