Handle headers with string keys

nasark commented 10 months ago

Message hashes can also be received with string keys instead of symbols, this was causing nil values to be retrieved from the header hash when using the .values_at method, resulting in failures when using these values to invoke methods later on

For example (notice how ems/sender and event types are empty in logging):

Nov 28 16:00:37 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]:  INFO -- evm: MIQ(MiqQueue.process_topic_message) Event received: topic(manageiq.ems), event({"event_type"=>"USER_ADD_DISK_TO_VM", "source"=>"RHEVM", "message"=>"Add-Disk operation of Dave_Test0), sender(), type()
Nov 28 16:00:37 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]:  INFO -- evm: MIQ(MiqQueue.process_topic_message) Event processed
Nov 28 16:00:37 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]: DEBUG -- evm: MIQ(MiqQueue.process_topic_message) HEADERS: {"sender"=>"1000000000003", "event_type"=>"USER_ADD_DISK_TO_VM_FINISHED_SUCCESS", "encoding"=>"json"}
Nov 28 16:00:37 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]:  INFO -- evm: MIQ(MiqQueue.process_topic_message) Event received: topic(manageiq.ems), event({"event_type"=>"USER_ADD_DISK_TO_VM_FINISHED_SUCCESS", "source"=>"RHEVM", "message"=>"The disk Dave_T), sender(), type()
Nov 28 16:00:37 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]:  INFO -- evm: MIQ(MiqQueue.process_topic_message) Event processed
Nov 28 16:00:40 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]:  INFO -- evm: MIQ(EmsEventHelper#before_handle) Processing EMS event [USER_ADD_DISK_TO_VM] chain_id [] on EMS []...
Nov 28 16:00:40 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]: ERROR -- evm: [NoMethodError]: undefined method `tenant_identity' for nil:NilClass  Method:[block (2 levels) in <class:LogProxy>]
Nov 28 16:00:40 agrare-im-rhv.rtp.raleigh.ibm.com evm[85076]: ERROR -- evm: /var/www/miq/vmdb/app/models/ems_event.rb:268:in `tenant_identity'
                                                              /opt/IBM/infrastructure-management-gemset/bundler/gems/bluecf-automation_engine-04fdd2d78066/lib/miq_automation_engine/engine/miq_ae_event.rb:136:in `call_automate'
                                                              /opt/IBM/infrastructure-management-gemset/bundler/gems/bluecf-automation_engine-04fdd2d78066/lib/miq_automation_engine/engine/miq_ae_event.rb:33:in `raise_ems_event'

@miq-bot assign @agrare @miq-bot add_labels bug, kafka

kbrock commented 10 months ago

good to see that activesupport is also in the gemspec

agrare commented 10 months ago

https://github.com/ManageIQ/manageiq-messaging/releases/tag/v1.4.1 has been released with this fix

ManageIQ / manageiq-messaging

Handle headers with string keys #82