search

ManageIQ / manageiq-pods

ManageIQ on Kubernetes and OpenShift
Apache License 2.0
51 stars 100 forks source link

Revert default messaging change #1026

Closed nasark closed 8 months ago

nasark commented 8 months ago

Revert https://github.com/ManageIQ/manageiq-pods/pull/1024

@miq-bot add_labels quinteros/yes?, bug @miq-bot assign @Fryguy

miq-bot commented 8 months ago

Checked commit https://github.com/nasark/manageiq-pods/commit/fbb5e00069a17255b8b65ac308593309fcb4a946 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :star:

Fryguy commented 8 months ago

I'm good with this for now, but I'm thinking we should do it differently for the future. For example, for the other dependent services, we don't have a special "deployXService" parameter. Instead we drive off of whether the HOSTNAME parameter is configured or not. This lets us know if an "external" service is created already and then we don't need to spin up our own.

Fryguy commented 8 months ago

Backported to quinteros in commit b242f7a6addbf892623e072ecd9aeabe5aba5edb.

commit b242f7a6addbf892623e072ecd9aeabe5aba5edb
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jan 5 10:18:16 2024 -0500

    Merge pull request #1026 from nasark/revert_default_msging_true

    Revert default messaging change

    (cherry picked from commit 051948292ebe3f619dd687a9fc314ec825a076f2)