Move messaging configuration to file and deprecate deployMessagingService flag

nasark commented 7 months ago

move messaging config from env vars to file
the configs will be stored in secrets and mounted as a projected volume since the kafka user password is located in another secret created by strimzi
kafka user secret naming convention normalized to match downstream cr.Spec.AppName-user -> cr.Spec.AppName-kafka-admin so that upstream and downstream can both use func MessagingEnvSecret
moving the config to secrets allows us to check the hostname to see whether kafka resources should be deployed or not in the case of an external kafka. This allows us to fully deprecate cr.Spec.DeployMessagingService

Depends on:

[ ] https://github.com/ManageIQ/manageiq/pull/22859

@miq-bot assign @bdunne @miq-bot add_reviewer @Fryguy

miq-bot commented 7 months ago

@nasark unrecognized command 'enhancement', ignoring...

Accepted commands are: add_label, add_reviewer, request_review, assign, close_issue, cross_repo_test, move_issue, remove_label, rm_label, remove_reviewer, set_milestone, unassign

nasark commented 7 months ago

@miq-bot add_label quinteros/yes?

miq-bot commented 7 months ago

Checked commits https://github.com/nasark/manageiq-pods/compare/6c880dd99021c292fb3853dc83e150a28d3d8387~...21cd0535a32ee892598ec9a2611a16aa77bfefd5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :star:

miq-bot commented 2 months ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

ManageIQ / manageiq-pods

Move messaging configuration to file and deprecate deployMessagingService flag #1041