Open tariksimsek opened 7 months ago
@bdunne Can you take a look at this one? I think we have a problem with our tagging script where it doesn't handle changing the image tags.
For example, when I checked out petrosian-1 code, I also see that it's pointing to latest-petrosian in the code
04:36:28 ~/dev/manageiq-pods ((petrosian-1)) (3.0.6) ✗ git grep petrosian
README.md:3:[![CI](https://github.com/ManageIQ/manageiq-pods/actions/workflows/ci.yaml/badge.svg?branch=petrosian)](https://github.com/ManageIQ/manageiq-pods/actions/workflows/ci.yaml)
README.md:6:[![Build history for petrosian branch](https://buildstats.info/github/chart/ManageIQ/manageiq-pods?branch=petrosian&buildCount=50&includeBuildsFromPullRequest=false&showstats=false)](https://github.com/ManageIQ/ma>
bin/build:3:TAG=latest-petrosian
bin/remove_images:4:TAG=latest-petrosian
images/manageiq-base-worker/Dockerfile:2:ARG FROM_TAG=latest-petrosian
images/manageiq-base/Dockerfile:50: https://rpm.manageiq.org/release/16-petrosian/el8/noarch/manageiq-release-16.0-1.el8.noarch.rpm && \
images/manageiq-base/Dockerfile:53: if [[ "$RELEASE_BUILD" != "true" ]]; then dnf config-manager --enable manageiq-16-petrosian-nightly; fi && \
images/manageiq-orchestrator/Dockerfile:2:ARG FROM_TAG=latest-petrosian
images/manageiq-ui-worker/Dockerfile:2:ARG FROM_TAG=latest-petrosian
images/manageiq-webserver-worker/Dockerfile:2:ARG FROM_TAG=latest-petrosian
manageiq-operator/README.md:37: $ sed -i 's|docker.io/manageiq/manageiq-operator:latest-petrosian|docker.io/<your_username_or_organization>/manageiq-operator:latest-petrosian|g' config/manager/manager.yaml
manageiq-operator/api/v1alpha1/helpers/miq-components/cr.go:247: return "latest-petrosian"
manageiq-operator/api/v1alpha1/manageiq_types.go:263: // Deprecated: Image tag used for the orchestrator and worker deployments (default: latest-petrosian)
manageiq-operator/config/crd/bases/manageiq.org_manageiqs.yaml:243: worker deployments (default: latest-petrosian)'
manageiq-operator/config/manager/manager.yaml:18: image: docker.io/manageiq/manageiq-operator:latest-petrosian
I think we need to change the tagging script to also change these various image tags. Then we can build from that tag.
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master
, please reply with all of the information you have about it in order to keep the issue open.
This issue has been automatically marked as stale because it has not been updated for at least 3 months.
If you can still reproduce this issue on the current release or on master
, please reply with all of the information you have about it in order to keep the issue open.
Describe the issue you are having and what you expected to happen. Image tags are wrong in the yaml files
Describe the steps to reproduce, including any log snippets and stack traces that will help diagnose. Use petrosian version of manageiq-operator
Describe your environment, including
Petrosian
All image names are wrong for this version. I checked in the docker hub . It is petrosian-1 but there is no latest-petrosian image. Please fix in the docker hub or in the yaml. Operator launches orchestrator and i can't change image tag there .