search

ManageIQ / manageiq-pods

ManageIQ on Kubernetes and OpenShift
Apache License 2.0
50 stars 100 forks source link

Remove creation of manageiq.liveness-check topic #1101

Closed nasark closed 1 month ago

nasark commented 2 months ago

We no longer use a push/pop approach as health check for kafka via the orchestrator and so this topic no longer needs to be created

Ref: https://github.com/ManageIQ/manageiq/pull/23020

@miq-bot assign @bdunne @miq-bot add_reviewers @bdunne, @Fryguy @miq-bot add_labels bug, radjabov/yes?

nasark commented 2 months ago

Need a cr migration to remove the manageiq.liveness-check topic that is already deployed

nasark commented 1 month ago

@bdunne Added the CR migration, please review

miq-bot commented 1 month ago

Checked commits https://github.com/nasark/manageiq-pods/compare/905ebb3a686f7ce1e882a558d19273c16eab1d63~...73b87c552ca1f7acd4fb7e027c9b006392feb355 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :star:

Fryguy commented 1 month ago

Backported to radjabov in commit 2a49d1b638270c82ad9169d9e2c47cebb0d0ff3a.

commit 2a49d1b638270c82ad9169d9e2c47cebb0d0ff3a
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Fri May 24 13:52:54 2024 -0400

    Merge pull request #1101 from nasark/remove_health_check_topic

    Remove creation of manageiq.liveness-check topic

    (cherry picked from commit 3ee8237f958bfeb15476c928f0da640a118d591c)