search

ManageIQ / manageiq-pods

ManageIQ on Kubernetes and OpenShift
Apache License 2.0
51 stars 100 forks source link

Update go to v1.23 #1148

Closed bdunne closed 1 month ago

bdunne commented 1 month ago

Drop the toolchain and move minimum to 1.23

"If the toolchain line is omitted, the module or workspace is considered to have an implicit toolchain goV line, where V is the Go version from the go line." -https://go.dev/doc/toolchain

miq-bot commented 1 month ago

Checked commits https://github.com/bdunne/manageiq-pods/compare/4e35522bfb4f983d3afa8b3efd15824daf8c1a6c~...f6757d7c9680d960f39e85daed7d389ed96839fb with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cake:

bdunne commented 1 month ago

Also interesting that when using go 1.22 (go 1.22 in go.mod) if you go mod tidy it will add the toolchain line for you, but it doesn't do that on 1.23.