search

ManageIQ / manageiq-pods

ManageIQ on Kubernetes and OpenShift
Apache License 2.0
51 stars 100 forks source link

Added ManageIQ Status with conditions, versions and ingress endpoint info #973

Closed sudhir-kelkar closed 1 year ago

sudhir-kelkar commented 1 year ago
  1. This PR adds support for ManageIQ CR status. With this status implementation we are adding status conditions, ingress endpoint info and operator/operand version to the CR status.

Fixes #https://github.ibm.com/katamari/dev-issue-tracking/issues/23259

bdunne commented 1 year ago

@Fryguy Can you also take a look at this?

Fryguy commented 1 year ago

Overall LGTM, though I admit I'm not a go person. I agree with @bdunne's comments otherwise.

miq-bot commented 1 year ago

Checked commits https://github.com/sudhir-kelkar/manageiq-pods/compare/2ba13d9fca139838b145966965966b37d4523796~...a9fa7ae80bd017db340d0a7d75b1b07389d3159d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 1 offense detected

**