search

ManageIQ / manageiq-pods

ManageIQ on Kubernetes and OpenShift
Apache License 2.0
51 stars 100 forks source link

Move util.go to miq-component/utils subpackage #993

Open nasark opened 11 months ago

nasark commented 11 months ago

Currently if util functions are needed elsewhere, the entire miq-components package needs to be pulled. It would be nice to be able to pull in just the util methods, this is especially useful for the downstream operator

@miq-bot assign @Fryguy @miq-bot add_reviewer @bdunne @miq-bot add_labels enhancement, refactoring

nasark commented 11 months ago

Marking as WIP since I'm not exactly sure how to test this before merging

miq-bot commented 11 months ago

Checked commit https://github.com/nasark/manageiq-pods/commit/7f9695addc45f82d49b0b2804385368ce325db65 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 0 files checked, 0 offenses detected Everything looks fine. :cookie:

nasark commented 11 months ago

Successfully tested this by swapping all github.com/ManageIQ/manageiq-pods references with my fork github.com/nasark/manageiq-pods, then pulling the package downstream using the commit hash go get -d -u github.com/nasark/manageiq-pods/manageiq-operator@<commit-hash>

Fryguy commented 11 months ago

Nice - Looks good to me.

I did expect more "deletes" where copy-pasted methods were switch to using the common methods, or is that a follow up?

miq-bot commented 10 months ago

This pull request is not mergeable. Please rebase and repush.

miq-bot commented 7 months ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot commented 4 months ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

miq-bot commented 1 month ago

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).