search

ManageIQ / manageiq-pods

ManageIQ on Kubernetes and OpenShift
Apache License 2.0
51 stars 100 forks source link

Fix route permissions issues after #989 #996

Closed bdunne closed 11 months ago

bdunne commented 11 months ago

routes: E0928 15:56:00.508746 1 reflector.go:147] pkg/mod/k8s.io/client-go@v0.28.0-rc.0/tools/cache/reflector.go:229: Failed to watch v1.Route: failed to list v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1" W0928 15:56:44.778213 1 reflector.go:535] pkg/mod/k8s.io/client-go@v0.28.0-rc.0/tools/cache/reflector.go:229: failed to list *v1.Route: routes.route.openshift.io is forbidden: User "system:serviceaccount:petrosian-1:manageiq-operator" cannot list resource "routes" in API group "route.openshift.io" in the namespace "petrosian-1"

routes/custom-host: 2023-09-28T16:30:38Z ERROR Reconciler error {"controller": "manageiq", "controllerGroup": "manageiq.org", "controllerKind": "ManageIQ", "ManageIQ": {"name":"manageiq-sample","namespace":"petrosian-1"}, "namespace": "petrosian-1", "name": "manageiq-sample", "reconcileID": "78aec8d7-f66d-4d63-8203-60f031384f19", "error": "Route.route.openshift.io \"httpd\" is invalid: spec.host: Forbidden: you do not have permission to set the host field of the route"}

miq-bot commented 11 months ago

Checked commit https://github.com/bdunne/manageiq-pods/commit/3d874afbba79eeaeeaab6548c90ae05830d94fde with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 1 offense detected

**

Fryguy commented 11 months ago

@bdunne Does this need to go back to petrosian?

Fryguy commented 11 months ago

Backported to quinteros in commit 61553a39260c3182f2e9169a17f82f27328b7b14.

commit 61553a39260c3182f2e9169a17f82f27328b7b14
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Sep 29 09:41:18 2023 -0400

    Merge pull request #996 from bdunne/route_permissions

    Fix route permissions issues after #989

    (cherry picked from commit 7f247673f5d87f9bc532f3f5b2a09e4b64c6aacb)
bdunne commented 11 months ago

@bdunne Does this need to go back to petrosian?

No, https://github.com/ManageIQ/manageiq-pods/pull/989 only went back to quinteros