Enhance Inventory's features - follow-up - Githubissues

ManageIQ / manageiq-providers-cisco_intersight

ManageIQ provider for Cisco Intersight

Apache License 2.0

2 stars 15 forks source link

Enhance Inventory's features - follow-up #39

Closed ghost closed 2 years ago

ghost commented 2 years ago

This PR is a follow-up PR to https://github.com/ManageIQ/manageiq-providers-cisco_intersight/pull/35. It address code style comments in the original pull request, made by @agrare.

To summarize, the following changes have been made:

Replace find_by with index_by function for the sake of efficiency
Renamed function build_physical_servers to singular
Renamed function build_physical_server_computer_systems to singular
Removed :type attribute in persister as this is done automatically in ManageIQ core. The attribute :type is included in inventory tests.
Removed inclusion of collection physical_server_network_ports

The changes don't change the actual data in inventory. Consequently, no new tests had to be written.

ghost commented 2 years ago

Thank you for thoroughly reviewing the code @agrare!