search

ManageIQ / manageiq-providers-cisco_intersight

ManageIQ provider for Cisco Intersight
Apache License 2.0
2 stars 15 forks source link

[NAJDORF] Remove merges related to physical_server_profiles #62

Closed agrare closed 2 years ago

agrare commented 2 years ago

Physical Server Profiles were added to core in master/oparin and required a schema change which cannot be backported to najdorf.

This reverts any merges related to physical_server_profiles from the najdorf branch:

miq-bot commented 2 years ago

Checked commits https://github.com/agrare/manageiq-providers-cisco_intersight/compare/d4bff69db083d459f04b9cc12404ffbb2007cfef~...f477d60ea1d578b741d20d89b163a923a8bcf5fa with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 6 files checked, 0 offenses detected Everything looks fine. :cake:

agrare commented 2 years ago

cc @Fryguy

Fryguy commented 2 years ago

Why is the fix yarn one being reverted?

agrare commented 2 years ago

Because https://github.com/ManageIQ/manageiq-providers-cisco_intersight/pull/51 was the only javascript and keeping #56 was causing conflicts.

Is that still needed if we don't have any toolbar helpers or js code in the repo? I can fix the conflicts I just thought it wasn't needed.

Fryguy commented 2 years ago

Oh I see...the entirety of package.json and yarn.lock will be gone. This is fine.