Split ibm cloud credentials from ibm classic infra credentials

[jrafanie]

I think this simplifies the required field logic. We'll need to make sure connecting from within the runner works but this is the start of enabling that work.

[agrare]

Makes sense to me, @putmanoj can you confirm this will work for opentofu-runner / ibm_cloud provider

[Fryguy]

Only comment I have here is I think it should it be "IBM Cloud Classic Infrastructure" vs "IBM Classic Infrastructure"? (it's this way in various strings, class names, factory names etc, so I think it would have to change everywhere)

[jrafanie]

Only comment I have here is I think it should it be "IBM Cloud Classic Infrastructure" vs "IBM Classic Infrastructure"? (it's this way in various strings, class names, factory names etc, so I think it would have to change everywhere)

My goal was to avoid confusing people by having IBM Cloud and IBM Cloud Classic Infrastructure in the select list. I saw Classic Infrastructure all over the place here and figured maybe we could use it: https://cloud.ibm.com/docs/account?topic=account-classic_keys. I'm good with whatever users would know the names to be.

[miq-bot]

Checked commits https://github.com/jrafanie/manageiq-providers-embedded_terraform/compare/a8356c6e196e1537e24cef9000f1b8d0173a22ba~...2827fc2ac1308c591f4e44d7e9496aff4cb7c370 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 8 files checked, 0 offenses detected Everything looks fine. :+1:

[jrafanie]

Only comment I have here is I think it should it be "IBM Cloud Classic Infrastructure" vs "IBM Classic Infrastructure"? (it's this way in various strings, class names, factory names etc, so I think it would have to change everywhere)

Ok, renamed to IBM Cloud Classic Infrastructure. The screenshots are updated.

[jrafanie]

Ready to go