search

ManageIQ / manageiq-providers-hawkular

ManageIQ plugin for the Hawkular provider
8 stars 33 forks source link

About how to proceed with alerts #99

Open aljesusg opened 6 years ago

aljesusg commented 6 years ago

Now when you create a alert of a type in Miq, hawkular is not creating the trigger for each Datasource. I have little knowledge about hawkular and I didn't know this. So here is the problem and some proposal.

Datasource

MiQ is looking for MI~R~[0b84c5546795/Local DMR~~]~MT~Datasource Pool Metrics~In Use Count

Hawkular is providing metrics in MI~R~[92da52a9b841/Local DMR~/subsystem=datasources/data-source=ExampleDS]~MT~Datasource Pool Metrics~In Use Count

/subsystem=datasources/data-source=ExampleDS

So If yo wanna trigger the alert you need to push data 

client.metrics.gauges.push_data("MI~R~[0b84c5546795/Local DMR~~]~MT~Datasource Pool Metrics~In Use Count",{:value=>37})

Mesagging

MiQ is looking MI~R~[0b84c5546795/Local~~]~MT~JMS Topic Metrics~Subscription Count

Hawkular is providing in MI~R~[92da52a9b841/Local~/subsystem=messaging-activemq/server=default/jms-topic=HawkularAlertsActionsTopic]~MT~JMS Topic Metrics~Subscription Count"

/subsystem=messaging-activemq/server=default/jms-topic=HawkularAlertsActionsTopic

With Web Sessions there isn't any problem.

Problems

Proposal Solutions

  1. fix de manageiq-providers-hawkular to create the trigger for each DataSource in the MiddlewareServer selected
  2. As @lucasponce told us in https://github.com/ManageIQ/manageiq-providers-hawkular/pull/88 make changes in MiQ UI to select Datasource type, Mesagging...

cc @abonas , @mtho11, @jdoyleoss

abonas commented 6 years ago

@jdoyleoss I think this is a functional decision first. so please see above :)

jshaughn commented 6 years ago

The comments in #88 are correct, and the options above make sense. My question is whether this is going to be resolved for TP3. Because if not then we should wait for Prometheus migration and then proceed.

As for the approach, I'd probably suggest option 2, being able to assign to specific DS or Messaging entities. The alternative could result in a lot of unnecessary triggers and possibly unwanted alerts.

aljesusg commented 6 years ago

I am working in the second option I think is the best too.

jdoyleoss commented 6 years ago

I agree the second option is the better option. Let's pursue that.

~john

On Fri, Nov 10, 2017 at 10:44 AM, Alberto Gutierrez < notifications@github.com> wrote:

I am working in the second option I think is the best too.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ManageIQ/manageiq-providers-hawkular/issues/99#issuecomment-343507601, or mute the thread https://github.com/notifications/unsubscribe-auth/AAfbZQ7eXEKn7HRVH9Zg1LIiCFWrTg0oks5s1G9kgaJpZM4QTRbt .

abonas commented 6 years ago

I agree with the second option. this is NOT for gaprindashvili though.

abonas commented 6 years ago

@aljesusg / @jdoyleoss please log an appropriate JMAN4 as this is a functional enhancement

miq-bot commented 6 years ago

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!