search

ManageIQ / manageiq-providers-ibm_cic

Apache License 2.0
1 stars 11 forks source link

Get cpu_speed from cic to set into hardware. #12

Closed lidanbj closed 2 years ago

lidanbj commented 2 years ago

Override parse_vm to set cpu_speed to hardware. this cpu_speed is from cic server object by fog:openstack api call.

agrare commented 2 years ago

Thanks for the PR @lidanbj !

I think this should be two different PRs since the changes are unrelated.

lidanbj commented 2 years ago

@agrare Thanks very much for the review comments. They are very helpful. 👍 I have updated related code. please help to review. Thanks.!~

agrare commented 2 years ago

Just the one comment @lidanbj then LGTM, I don't see this property in the current vcr_cassettes which would allow us to test this out, do you have a system where you are seeing this property returned and we could re-record the cassettes?

agrare commented 2 years ago

Looks good just the rubocop trailing whitespace issue so I'll fix that for you

miq-bot commented 2 years ago

Checked commits https://github.com/lidanbj/manageiq-providers-ibm_cic/compare/ccf0199f4aa6e590399982aa280b885f813f186e~...891a72a844a62bb47ca96754510f7ffd319fae5f with ruby 2.6.9, rubocop 1.19.1, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cookie:

dongcc commented 2 years ago

Just the one comment @lidanbj then LGTM, I don't see this property in the current vcr_cassettes which would allow us to test this out, do you have a system where you are seeing this property returned and we could re-record the cassettes?

@agrare many thanks for reviewing this, as for the test system, one compute node of the previous 205 env that I shared will report such property.

Fryguy commented 2 years ago

Backported to najdorf in commit 4a602dc7d9196318c1d42f26089cbe0fae0110cd.

commit 4a602dc7d9196318c1d42f26089cbe0fae0110cd
Author: Adam Grare <adam@grare.com>
Date:   Wed Apr 20 09:57:10 2022 -0400

    Merge pull request #12 from lidanbj/ibm/cic-provider

    Get cpu_speed from cic to set into hardware.

    (cherry picked from commit 0c6e7205bf916f35d0cdd45e322a4821513da138)