Add Service Catalog Provisioning support

agrare commented 1 year ago

Add a ProvisionWorkflow subclass and supports :catalog to allow IBM CIC providers to provision VMs via Service Catalog

Depends on:

[x] https://github.com/ManageIQ/manageiq-providers-openstack/pull/840

Fixes https://github.com/ManageIQ/manageiq-providers-ibm_cic/issues/28

agrare commented 1 year ago

@miq-bot cross-repo-tests https://github.com/ManageIQ/manageiq-providers-openstack/pull/840

miq-bot commented 1 year ago

Some comments on commits https://github.com/agrare/manageiq-providers-ibm_cic/compare/4c5fc7ae0f96c625b8199eb1cc7310f63a09ea99~...009375689cce6cd55ab9664215ee55426dc4f69c

spec/models/manageiq/providers/ibm_cic/cloud_manager/provision_workflow_spec.rb

[ ] :warning: - 15 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
[ ] :warning: - 159 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
[ ] :warning: - 173 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
[ ] :warning: - 427 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
[ ] :warning: - 71 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

miq-bot commented 1 year ago

Checked commits https://github.com/agrare/manageiq-providers-ibm_cic/compare/4c5fc7ae0f96c625b8199eb1cc7310f63a09ea99~...009375689cce6cd55ab9664215ee55426dc4f69c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 12 files checked, 1 offense detected

content/miq_dialogs/miq_provision_ibm_cic_dialogs_template.yaml

[ ] :warning: - Line 103, Col 121 - 136 > 120 characters) (line-length - line too long

agrare commented 1 year ago

Okay cross-repo is green

agrare commented 1 year ago

cc @Fryguy

Fryguy commented 1 year ago

Backported to petrosian in commit 79105b09a354cd8c2c0eb1cc94a61667f97827a3.

commit 79105b09a354cd8c2c0eb1cc94a61667f97827a3
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Mar 9 11:05:50 2023 -0500

    Merge pull request #31 from agrare/add_catalog_support_ibm_cic

    Add Service Catalog Provisioning support

    (cherry picked from commit fcce82c762ebaabf9bcb1764667c6d10e42e9af8)

ManageIQ / manageiq-providers-ibm_cic

Add Service Catalog Provisioning support #31