ManageIQ / manageiq-providers-ibm_cloud

ManageIQ plugin for the IBM Cloud provider
Apache License 2.0
5 stars 36 forks source link

PowerVS VM provisioning: Memory, CPU and storage quotas not enforced #454

Open jaywcarman opened 1 year ago

jaywcarman commented 1 year ago

When provisioning PowerVS VMs, memory, cpu and storage quotas are not enforced.

Most cloud providers use a Flavor to set provisioning resource allocations. The PowerVS provider sub-classes Flavor into:

The SystemType instances are used only to set the underlying host system type that the VM will be place on. None of the allocation attributes are set.

The SAPProfile instances are closer to a standard flavor, setting :cpu_total_cores and :memory.

The MIQ VM provision, reconfigure, etc. request classes use a common method to calculate memory, number_of_cpus, storage and others. They all assume that the flavor_obj will provide the allocation information necessary for automate to enforce quotas, but due to the unconventional user of flavors described here that is not working.

Initially I plan to fix just memory, since an exception is raised when automation try to multiply nil by the number of VMs requested. CPUs will be interesting since PowerVS allocates "entitled processors" (float) but also collects vCPUs in inventory (after the VM is provisioned). Storage also may need to be fixed separately, so I'll include a checklist to track progress individually:

kbrock commented 1 year ago

Is is possible to change PowerVS so it sets the values rather than relying upon subclassing?

miq-bot commented 1 year ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

miq-bot commented 9 months ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

miq-bot commented 6 months ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

miq-bot commented 3 months ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

miq-bot commented 5 days ago

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.