search

ManageIQ / manageiq-providers-ibm_cloud

ManageIQ plugin for the IBM Cloud provider
Apache License 2.0
5 stars 36 forks source link

Rename placement_type to the standard instance_type #457

Closed agrare closed 1 year ago

agrare commented 1 year ago

There is core code which depends on having an :instance_type option for Cloud-type provision requests.

This should be merged with the schema change: https://github.com/ManageIQ/manageiq-schema/pull/692

miq-bot commented 1 year ago

Checked commit https://github.com/agrare/manageiq-providers-ibm_cloud/commit/bb18c141870ac1918cf0a11f92b1924ed1b1267c with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :cookie:

jrafanie commented 1 year ago

LGTM. What do you think about a data migration? I think this is only found in miq_requests table but I can't be sure.

jrafanie commented 1 year ago

One last question. Is this covered by tests?

jrafanie commented 1 year ago

One last question. Is this covered by tests?

Offline discussion. It's not covered by tests but not an insignificant amount of effort to add. We'll consider doing this after merging this PR if we find a easier way to test it.

agrare commented 1 year ago

This introduced an issue where the System Profile dropdown is no longer rendered by the UI, resolved by https://github.com/ManageIQ/manageiq-providers-ibm_cloud/pull/461