drop use of unsupported_reason_add an supports_feature

ManageIQ / manageiq-providers-ibm_cloud

ManageIQ plugin for the IBM Cloud provider

Apache License 2.0

5 stars 36 forks source link

drop use of unsupported_reason_add an supports_feature #486

Closed kbrock closed 8 months ago

kbrock commented 8 months ago

part of:

https://github.com/ManageIQ/manageiq/pull/22898

Dropping use of supports_feature?. Using supports?(feature) instead Deprecating unsupported_reason_add. Returning the string instead

Note, these are all the same:

unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports_feature2?
unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports?(:feature2)
unsupported_reason(:feature2) unless supports?(:feature2)
unsupported_reason(:feature2)

kbrock commented 8 months ago

update:

fixed missing return statements

miq-bot commented 8 months ago

Checked commit https://github.com/kbrock/manageiq-providers-ibm_cloud/commit/2309576a4b49cf31f00cae729ba4011549a47b79 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 10 files checked, 0 offenses detected Everything looks fine. :cookie: