search

ManageIQ / manageiq-providers-ibm_terraform

Apache License 2.0
2 stars 27 forks source link

Retrieve ibm vpc hostname #54

Closed epostea closed 3 years ago

epostea commented 3 years ago

This PR is for issue: https://github.com/ManageIQ/manageiq-providers-ibm_terraform/issues/52

The terraform state structure is different for IBM classic vs VPC virtual machines. The hostname can be retrieved from details.hostname (classic resources) or details.name (VPC resources)

epostea commented 3 years ago

@miq-bot add_label bug

epostea commented 3 years ago

I didn't realize @k-chu already raised a PR for the same issue https://github.com/ManageIQ/manageiq-providers-ibm_terraform/pull/53 :-)

Closing this PR.

miq-bot commented 3 years ago

Checked commit https://github.com/epostea/manageiq-providers-ibm_terraform/commit/f29fe5a9f8ef3b6c80a76ad3f0bf785639c5c9dd with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :trophy: