ManageIQ / manageiq-providers-kubernetes

ManageIQ plugin for the Kubernetes provider.
https://kubernetes.io/
Apache License 2.0
7 stars 63 forks source link

Removed the `auth_key` from list of Validation Dependencies in Metrics and Alerts #492

Closed DavidResende0 closed 1 year ago

DavidResende0 commented 1 year ago

Right now, when editing the default endpoint token of a provider like Openshift, the provider form forces the user to revalidate the Metrics and Alerts endpoints as well however, this isn't apparent to the user unless they switch to that tab and check which can lead to confusion when trying to save.

Before: image image image

After: image

Note: This is a temporary fix. The goal is to later undo this change and introduce a way for the ui to alert the user that they have to revalidate the other endpoints before saving their edits.

DavidResende0 commented 1 year ago

@miq-bot assign @Fryguy, @agrare

miq-bot commented 1 year ago

@DavidResende0 'Fryguy, agrare' is an invalid assignee, ignoring...

DavidResende0 commented 1 year ago

@miq-bot assign @Fryguy @miq-bot assign @agrare

miq-bot commented 1 year ago

Checked commit https://github.com/DavidResende0/manageiq-providers-kubernetes/commit/828df862e8384af5b42cd9634223f95731a840b8 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :cake:

Fryguy commented 1 year ago

As discussed we will remove this for now to unlock the Save button and then follow up with a more thorough fix.

Fryguy commented 1 year ago

Backported to petrosian in commit 7f77b35507cdc06a3ebce8697cfb4d9e0a092e9f.

commit 7f77b35507cdc06a3ebce8697cfb4d9e0a092e9f
Author: Jason Frey <fryguy9@gmail.com>
Date:   Fri Jun 9 17:14:28 2023 -0400

    Merge pull request #492 from DavidResende0/remove-validation-dependecies

    Removed the `auth_key` from list of Validation Dependencies in Metrics and Alerts

    (cherry picked from commit 7be0a737edac7c0af5b43fdef6bfac1627826a33)
agrare commented 1 year ago

This introduced a bug where adding a new token and a metrics endpoint at the same time (basically the new provider workflow) fails validation because the metrics endpoint doesn't have access to the default authentication bearer token.