Check metrics authentication validity before perf_capture_queue

ManageIQ / manageiq-providers-kubernetes

ManageIQ plugin for the Kubernetes provider.

https://kubernetes.io/

Apache License 2.0

7 stars 63 forks source link

Check metrics authentication validity before perf_capture_queue #493

Closed agrare closed 1 year ago

agrare commented 1 year ago

Check that the EMS's metrics authentication is valid before queueing perf_capture calls, potentially flooding the queue with calls that are going to fail later.

requires:

[x] https://github.com/ManageIQ/manageiq/pull/22567

jrafanie commented 1 year ago

Nice

miq-bot commented 1 year ago

Checked commits https://github.com/agrare/manageiq-providers-kubernetes/compare/be53bdc1bb9d0f394112211aa81de1401059015e~...0c258a3c6e8451afc3fe956fbb5a1d59a47d717e with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 4 files checked, 1 offense detected

spec/factories/ext_management_system.rb

[ ] :exclamation: - Line 18, Col 27 - Rails/SkipsModelValidations - Avoid using update_all because it skips validations.

agrare commented 1 year ago

@kbrock can you re-review? I refactored the specs to use let() and pulled out target_name into a method to keep the logic in one place.

Fryguy commented 1 year ago

Backported to petrosian in commit 968fcea19c17ceab63e9272a3df91a85461d58aa.

commit 968fcea19c17ceab63e9272a3df91a85461d58aa
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Tue Jun 13 18:21:24 2023 -0400

    Merge pull request #493 from agrare/check_metrics_connection_validity_before_queueing_perf_captures

    Check metrics authentication validity before perf_capture_queue

    (cherry picked from commit ba04739fc4ab3eee4625630ec4622dd71d576d67)