search

ManageIQ / manageiq-providers-kubernetes

ManageIQ plugin for the Kubernetes provider.
https://kubernetes.io/
Apache License 2.0
7 stars 63 forks source link

Fix started_at/finished_at always being nil #496

Closed agrare closed 1 year ago

agrare commented 1 year ago

The state_info had symbol keys like :startedAt and :finishedAt and we were looking for string keys like "startedAt" and "finishedAt" causing these values to always be nil even if data existed in the API response.

kbrock commented 1 year ago

@Fryguy Is it possible to raise the priority of this bugfix? Or are we thinking the deleted_on logic is not critical?

Fryguy commented 1 year ago

@kbrock we'll backport to petrosian as part of the set, yes. Even so, we'll need to deal with existing records anyway.

miq-bot commented 1 year ago

Checked commit https://github.com/agrare/manageiq-providers-kubernetes/commit/634e763d7a7213f44d26d6e4e0818d28d73c698d with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint 2 files checked, 0 offenses detected Everything looks fine. :trophy:

kbrock commented 1 year ago

Rebase please. I think kubernetes HEAD fixes this issue

Fryguy commented 1 year ago

Backported to petrosian in commit 7793ce09194180ee171d172d73f9de22c95afdbb.

commit 7793ce09194180ee171d172d73f9de22c95afdbb
Author: Keenan Brock <keenan@thebrocks.net>
Date:   Fri Jul 14 16:09:47 2023 -0400

    Merge pull request #496 from agrare/fix_started_at_finished_at_timestamps

    Fix started_at/finished_at always being nil

    (cherry picked from commit 1c753fe979d1ecec638b211d88f9ff7af8d8ed92)