Closed agrare closed 1 year ago
@agrare Will we still log that we attempted the event? I'm wondering if we should be printing a "Skipping" or "Ignoring" message to the log at a minimum.
I'm going to rework this a bit since there won't be anything useful to log if we just return nil
app/models/manageiq/providers/kubernetes/container_manager/event_catcher_mixin.rb
@Fryguy ready for review
Backported to petrosian
in commit 272dade1b16cfb20c7c72bc5a7cfb43678fd5c6a.
commit 272dade1b16cfb20c7c72bc5a7cfb43678fd5c6a
Author: Jason Frey <fryguy9@gmail.com>
Date: Fri Aug 11 13:48:42 2023 -0400
Merge pull request #501 from agrare/reject_events_without_a_timestamp
Reject any events which do not have a timestamp
(cherry picked from commit c2df77bc3d66e712872a86e9ffac690342aca737)
The event timestamp is critical for uniquely identifying events and ensuring there are no duplicates.
We cannot properly handle events without a timestamp so we need to not queue these for the event handler.