search

ManageIQ / manageiq-providers-kubernetes

ManageIQ plugin for the Kubernetes provider.
https://kubernetes.io/
Apache License 2.0
7 stars 63 forks source link

Require kubeclient in connection_rescue_block #519

Closed agrare closed 6 months ago

agrare commented 6 months ago

Ensure that the Kubeclient::HttpError exception class is loaded in the connection_rescue_block method when verifying the prometheus endpoint.

[NameError]: uninitialized constant ManageIQ::Providers::Kubernetes::ContainerManager::Kubeclient
  rescue RestClient::Unauthorized, Kubeclient::HttpError => err
ERROR -- evm: /opt/manageiq/manageiq-gemset/bundler/gems/manageiq-providers-kubernetes-7e766229622c/app/models/manageiq/providers/kubernetes/container_manager.rb:596:in `rescue in connection_rescue_block'
  /opt/manageiq/manageiq-gemset/bundler/gems/manageiq-providers-kubernetes-7e766229622c/app/models/manageiq/providers/kubernetes/container_manager.rb:588:in `connection_rescue_block'
  /opt/manageiq/manageiq-gemset/bundler/gems/manageiq-providers-kubernetes-7e766229622c/app/models/manageiq/providers/kubernetes/container_manager.rb:570:in `verify_credentials'
  /var/www/miq/vmdb/app/models/mixins/verify_credentials_mixin.rb:28:in `verify_credentials?'                                   ^^^^^^^^^^
miq-bot commented 6 months ago

Checked commit https://github.com/agrare/manageiq-providers-kubernetes/commit/490e70e5d13d18c3fe07396d02ccf137207c53a5 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint 1 file checked, 0 offenses detected Everything looks fine. :+1:

Fryguy commented 6 months ago

Backported to radjabov in commit e56e15abb89a906aa230843227e4963dadff9715.

commit e56e15abb89a906aa230843227e4963dadff9715
Author: Jason Frey <fryguy9@gmail.com>
Date:   Thu Feb 29 18:00:59 2024 -0500

    Merge pull request #519 from agrare/require_kubeclient_connection_rescue_block

    Require kubeclient in connection_rescue_block

    (cherry picked from commit 11f0134c1df2b894d49a096ff78e88824ff8116f)