Removing inventory builder from Refresher

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.

https://kubevirt.io/

Apache License 2.0

4 stars 29 forks source link

Removing inventory builder from Refresher #119

Closed slemrmartin closed 6 years ago

slemrmartin commented 6 years ago

Replacing Inventory::Builder with Inventory.build instead.

Fixes BZ https://bugzilla.redhat.com/show_bug.cgi?id=1632131

[x] together with: #117
[x] based on #115

slemrmartin commented 6 years ago

@miq-bot add_label bug cc @pkliczewski

slemrmartin commented 6 years ago

.. @pkliczewski - now I'm waiting for new credentials to test it

miq-bot commented 6 years ago

Checked commit https://github.com/slemrmartin/manageiq-providers-kubevirt/commit/0e1fe1120d6dcb9064f2eec18067a8ceeb97fd07 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 1 file checked, 0 offenses detected Everything looks fine. :trophy:

slemrmartin commented 6 years ago

@pkliczewski tested, it's working

pkliczewski commented 6 years ago

@slemrmartin If the change is ready please remove wip flag.

pkliczewski commented 6 years ago

/cc @masayag

simaishi commented 6 years ago

Hammer backport details:

$ git log -1
commit 0b5e14cd1dd72e07c3635ff408fc4a7cea0c2c20
Author: Adam Grare <agrare@redhat.com>
Date:   Tue Oct 23 09:04:16 2018 -0400

    Merge pull request #119 from slemrmartin/missing-inv-builder-refresher

    Removing inventory builder from Refresher

    (cherry picked from commit 34362614b6c9c40376ecaa22ad57eb99d3febef9)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1632131