search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

gemspec: use latest fog-kubevirt #125

Closed pkliczewski closed 5 years ago

pkliczewski commented 5 years ago

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1660099

miq-bot commented 5 years ago

Checked commit https://github.com/pkliczewski/manageiq-providers-kubevirt/commit/f92af06e9033ce0821fb87e3fc7ef1bd075c4b34 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 0 files checked, 0 offenses detected Everything looks fine. :cake:

pkliczewski commented 5 years ago

/cc @agrare

pkliczewski commented 5 years ago

@agrare Travis failures seems not to be related to this change. Please take a look.

agrare commented 5 years ago

Hey @pkliczewski no it is because of this change, bundler just gives really bad error messages: https://travis-ci.org/ManageIQ/manageiq-providers-kubevirt/jobs/462722048#L620-L627

We'll need to coordinate this with PRs to master and manageiq-providers-kubernetes.

pkliczewski commented 5 years ago

@miq-bot added the hammer/yes

pkliczewski commented 5 years ago

There are couple of fixes in newer version which needs to be backported

miq-bot commented 5 years ago

@pkliczewski unrecognized command 'added', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, set_milestone

pkliczewski commented 5 years ago

@miq-bot add_label hammer/yes

pkliczewski commented 5 years ago

This PR fixes https://bugzilla.redhat.com/1660099

pkliczewski commented 5 years ago

@miq-bot add_label bug

pkliczewski commented 5 years ago

@miq-bot add_label blocker

simaishi commented 5 years ago

Hammer backport details:

$ git log -1
commit fca04ce5d98d380ca57d24a6724348d5b3d239f8
Author: Gregg Tanzillo <gtanzill@redhat.com>
Date:   Mon Dec 3 16:06:46 2018 -0500

    Merge pull request #125 from pkliczewski/master

    gemspec: use latest fog-kubevirt
    (cherry picked from commit 9b94e38db0d8b5567ddc3494bcd30f67cfac45e1)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1660099