search

ManageIQ / manageiq-providers-kubevirt

ManageIQ plugin for the Kubevirt provider.
https://kubevirt.io/
Apache License 2.0
4 stars 29 forks source link

refresh: Parser was never called #126

Closed pkliczewski closed 5 years ago

pkliczewski commented 5 years ago

With recent change [1] we introduced this regression where we stopped calling parser. This PR fixes the issue.

Fixes: https://bugzilla.redhat.com/1649629

[1] https://github.com/ManageIQ/manageiq-providers-kubevirt/pull/117

pkliczewski commented 5 years ago

@miq-bot add_label bug

pkliczewski commented 5 years ago

@miq-bot add_label hammer/yes

pkliczewski commented 5 years ago

fyi @slemrmartin

miq-bot commented 5 years ago

Checked commit https://github.com/pkliczewski/manageiq-providers-kubevirt/commit/8bb00da1ae78d7d4ebb32c1dc8439925956d9036 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 1 file checked, 0 offenses detected Everything looks fine. :cake:

agrare commented 5 years ago

cc @Ladas

pkliczewski commented 5 years ago

@agrare Thank you for helping with this one.

simaishi commented 5 years ago

Hammer backport details:

$ git log -1
commit 0c7dd9b8745686028836d918909dfd43cb13b9f3
Author: Adam Grare <agrare@redhat.com>
Date:   Fri Dec 7 11:20:25 2018 -0500

    Merge pull request #126 from pkliczewski/master

    refresh: Parser was never called
    (cherry picked from commit 0392c063ce89c1c4bcb225ea6868e660d6ee95c8)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1649629